Merged
Conversation
Jutho
reviewed
Mar 26, 2026
Jutho
reviewed
Mar 26, 2026
Jutho
reviewed
Mar 26, 2026
Member
Jutho
left a comment
Jutho
left a comment
There was a problem hiding this comment.
Two code suggestions but otherwise approved!
Codecov Report❌ Patch coverage is
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Member
Author
|
Test failures are due to |
lkdvos
added a commit
that referenced
this pull request
Mar 26, 2026
* add TruncationUnion implementation * add projection mooncake rules * Ensure `blocktype` is correctly inferred for CuArray * mark tests as no longer broken * type stability improvements type stability improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consists of some small fixes to unbreak the tests.
None of these should affect downstream users, as the ambiguity only hits a new feature, but it is required to make the tests of all current PRs pass.
The CUDA arrays where wrong
blocktypeimplementations, which made the algorithm selection trip. This was already tackled in #375, but I handled it slightly differently here by just making the overload more specific, to avoid accidentally running into this in the future. It does mean we rely a bit more on type inference for that, but I think this is a reasonable trade-off.